Jtdcftul

Recently during code review, my direct supervisor wrote a comment requesting a change on some code I submitted. Normally, that is not a problem (and I understand that is the very point of code reviews), but it turns out that his concern is based on incorrect information.

More specifically, he raised concerns over a certain language feature, and explained why that could be an issue - except that, in fact, the language does not work as he explained. This is supported by language documentation.

My question, then, is how do I explain to him (if at all) that his idea of how the language works is incorrect? Being at least one or two decades junior to him, I don't want to come off as arrogant. I would normally have no problem with sucking it up and making the change (it's as easy as deleting a comma) - but I also feel like that goes against the spirit of a code review.

Not a duplicate of How do I tell a coworker he's wrong?, since this is specifically about telling your seniors they are wrong.

Be humble.

I'm a bit confused here. My understanding was that feature X has property Y. Is there something I'm missing here which means this doesn't work in this case?

Much better to start from the assumption that you are the one that is wrong, rather than the other way round. If you're wrong, you'll learn something; if you were in fact right, you've now taught your manager something in a non-confrontational way.

As an important aside, while you say this is different from our other question, it isn't really: you should be humble with your peers and with your juniors as well.

You can simply "ask for more clarity" and show willingness to change but subtly indicating that his concerns are not valid. An email to this effect may help:

You have requested following changes in the code because of so and so reasons. However, my understanding of this language is that this problem will not occur because it instead works this way. I suppose I am missing something but could you please clarify or confirm that my understanding is wrong? If you have few minutes, I can show a demo of this and may be you can point out more specifically what your concerns are.

This way you will at least have a documented proof that you tried to correct him back. If he still insist, you can do whatever he requested and just hope it wont be a problem in the long run.

In reading some of these workplace problems, it brings back old memories where I worked in a SLC, UTAH company, in a manufacturing environment as a programmer. In looking back on it, I burned a bridge which I should of NEVER let happen. It was a bridge that I had to cross many times before. My supervisor was known as the company drunk, but he knew his stuff. He had many problems, but that side of him, was none of my business in the first place.
But NEVER tell your immdiate supervisor that he/she is wrong. NEVER! And never in front of his peers or any of his/her supvervisors. That a strike or nail in your coffin.
But before you runoff at the mouth on him/she being wrong, first take some extra time plus some extra effort(s) on your part and research it all the problems out where he/she 'might' be incorrect in full and provide alternate answers or solutions to solve the problem(s). Notice the careful wordings in the above statement??? Use words like "'might' be incorrect" NEVER 'Wrong'. Have supporting documents and answers to support your theories. After you've done your extra homework, set up a time to meet with your supervisor in a meeting form so that it fits his/hers' schedule, not yours! And go into that meeting with an attitude showing that you are workable, friendly, and happy and SHOW IT! One thing I learned with this past supervisor, he could read my attitude and body language and facial features and voice - know everything about me. And with all this effort and a meeting, you could either loose or win.
As my father would say, your supervisor holds the future of your job within the company you work in. In a sense, you are at his/hers' mercy. Oh, one thing I forgot, DON'T raise for voice for anything! Again, as I look back on this job, I could see places where the bridge was starting to burn. My job as a manufacturing programmer, is just like yours. All my work was reviewed by my supervisor period! And I recieved good marks and bad marks on my work and sometimes I was told to redo my programming work, and it was humbling!
So my advice to you as a from manufacturing environment programmer, It's up to you if you want the job, if you like the job and want to stay - it's up to you and your attitude plays a big part in your job. Remember, you are to make your supervisor look GOOD to everyone!! Enough of my preaching... Now enjoy your job.